Apply correct transformation for Products Searched event #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prayansh
reviewed
Mar 4, 2021
| @@ -80,7 +80,7 @@ public String key() { | |||
| EVENT_MAPPER.put("Product Added to Wishlist", Event.ADD_TO_WISHLIST); | |||
| EVENT_MAPPER.put("Product Shared", Event.SHARE); | |||
| EVENT_MAPPER.put("Product Clicked", Event.SELECT_CONTENT); | |||
| EVENT_MAPPER.put("Product Searched", Event.SEARCH); | |||
| EVENT_MAPPER.put("Products Searched", Event.SEARCH); | |||
There was a problem hiding this comment.
do we want to add a new mapper for Products Searched, rather than replacing the previous one? im guessing customers might be using Product Searched currently and this change would break that flow
There was a problem hiding this comment.
nvm, seems like the correct and only one to use is Products Searched (ref: https://github.com/segment-integrations/analytics-ios-integration-firebase/blob/master/Segment-Firebase/Classes/SEGFirebaseIntegration.m#L104), so its ok to replace here
prayansh
approved these changes
Mar 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per our Firebase docs we map the Products Searched event to the native Firebase method: https://segment.com/docs/connections/destinations/catalog/firebase/#event-mappings
This was mapped incorrectly as
Product Searched. It should beProducts Searched.