Logic to catch multiple forbidden chars #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prayansh
reviewed
Mar 1, 2021
| } | ||
|
|
There was a problem hiding this comment.
i like this change :). Makes the code more concise. Does it do anything different compared to the old functionality? i cant seem to spot the difference
There was a problem hiding this comment.
nvm found the diff. good spot on using replace instead of replaceAll. very subtle bug 😅
There was a problem hiding this comment.
The replaceall confused me too. From what I understand, the main difference is supplying a regex pattern which does not seem necessary for the simple transformations we're doing.
prayansh
reviewed
Mar 1, 2021
| @@ -169,6 +169,18 @@ public void makeKeyWithDot() { | |||
| verify(firebase).logEvent(eq("test_event"), bundleEq(new Bundle())); | |||
| } | |||
|
|
|||
| @Test | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently an evnet name like
test-event-dashed-and.dottedwill not be fully transformed to underscores which results in the event being rejected.Using replace instead of the replaceAll for the whitespace check. Not sure if I am missing something form the original implementation for that.