Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error this issue: Cannot assign to read only property 'onbefore… #1577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Connor-Knabe
Copy link

Fixes
Cannot assign to read only property 'onbeforeunload' of object '#'

#1082

There was another pull request that I don't believe was pulled in. This issue is still present in 3.0.1. Thanks!

@@ -52,7 +52,7 @@ Object.defineProperties(window, {
},
onbeforeunload: {
enumerable: true,
writable: false,
writable: true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should onunload be writable: true as well? L:50?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that onbeforeunload fixed this issue. I wouldn't touch onunload unless that was causing issues as well. Thanks for checking @nramirez!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants