Skip to content

fix(api): use requestor's permissions for request approval #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kinggeorges12 wants to merge 1 commit into from
Closed

fix(api): use requestor's permissions for request approval #2173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server/entity/MediaRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export class MediaRequest {
}

// Apply overrides if the user is not an admin or has the "advanced request" permission
const useOverrides = !user.hasPermission([Permission.MANAGE_REQUESTS], {
const useOverrides = !requestUser.hasPermission([Permission.MANAGE_REQUESTS], {
type: 'or',
});

Expand Down Expand Up @@ -337,7 +337,7 @@ export class MediaRequest {
media,
requestedBy: requestUser,
// If the user is an admin or has the "auto approve" permission, automatically approve the request
status: user.hasPermission(
status: requestUser.hasPermission(
[
requestBody.is4k
? Permission.AUTO_APPROVE_4K
Expand Down Expand Up @@ -447,7 +447,7 @@ export class MediaRequest {
media,
requestedBy: requestUser,
// If the user is an admin or has the "auto approve" permission, automatically approve the request
status: user.hasPermission(
status: requestUser.hasPermission(
[
requestBody.is4k
? Permission.AUTO_APPROVE_4K
Expand Down Expand Up @@ -485,7 +485,7 @@ export class MediaRequest {
(sn) =>
new SeasonRequest({
seasonNumber: sn,
status: user.hasPermission(
status: requestUser.hasPermission(
[
requestBody.is4k
? Permission.AUTO_APPROVE_4K
Expand Down
Loading