Skip to content

Conversation

@ale183
Copy link
Contributor

@ale183 ale183 commented Oct 27, 2025

Description

This PR changes the metadata provider to TMDB when using anidb for better season recognition

To-Dos

  • Disclosed any use of AI (see our policy)
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract

@ale183 ale183 requested a review from a team as a code owner October 27, 2025 13:26
@ale183 ale183 force-pushed the feature-animelist-tmdb branch from 919e33d to 1fa644d Compare November 26, 2025 16:19
Copy link
Member

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain a bit further why this change from TVDB to TMDB helps?
And shouldn't this be done depending on the current metadata provider (we now support TMDB and TVDB)?

@ale183
Copy link
Contributor Author

ale183 commented Nov 27, 2025

I kinda wrote the wrong thing in the description, the provider remains the same:
Before the change the provider was TMDB (more precisely TMDB using TVDB id) and the reference season from animelist.ts was tvdbSeason, this could generate some mismatches.
After this change the provider is still TMDB (but it uses the TMDB id from animelist.ts) and it references the correct season (tmdbSeason from animelist.ts).

I could use the method getMetadataProvider, but the variable tvShow in processShow has the type TmdbTvDetails | null, i think that this change should be done in another pr, but correct me if i'm wrong.

@ale183 ale183 requested a review from gauthier-th November 30, 2025 23:55
@ale183 ale183 force-pushed the feature-animelist-tmdb branch from 660872d to b0d02b3 Compare December 1, 2025 00:01
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label Dec 9, 2025
@ale183 ale183 force-pushed the feature-animelist-tmdb branch from b0d02b3 to 531c000 Compare December 10, 2025 02:16
@github-actions github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Dec 10, 2025
@ale183 ale183 force-pushed the feature-animelist-tmdb branch from 531c000 to 1c023a0 Compare December 15, 2025 16:03
@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label Dec 29, 2025
@github-actions
Copy link

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@ale183 ale183 force-pushed the feature-animelist-tmdb branch from 1c023a0 to 6370024 Compare December 31, 2025 12:35
@github-actions github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants