Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _class_default from containers #219

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Remove _class_default from containers #219

merged 1 commit into from
Feb 15, 2018

Conversation

fwkoch
Copy link
Contributor

@fwkoch fwkoch commented Feb 15, 2018

Using empty containers as defaults caused big problems and was not consistent with the rest of properties (see #169). This PR is not backwards compatible, but I think it is the right choice.

@codecov
Copy link

codecov bot commented Feb 15, 2018

Codecov Report

Merging #219 into dev will increase coverage by 0.04%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #219      +/-   ##
==========================================
+ Coverage   95.03%   95.08%   +0.04%     
==========================================
  Files          15       15              
  Lines        2114     2114              
==========================================
+ Hits         2009     2010       +1     
+ Misses        105      104       -1
Impacted Files Coverage Δ
properties/base/containers.py 88.75% <90.9%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5384fbc...237fe3d. Read the comment docs.

@fwkoch fwkoch merged commit af12a29 into dev Feb 15, 2018
@fwkoch fwkoch deleted the feat/no_list_default branch February 15, 2018 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant