Allow private properties #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gracefully ignores old doc orders if new properties have been added. It will only error if an invalid doc order is provided on in a class dict.
Codecov Report
@@ Coverage Diff @@
## dev #194 +/- ##
==========================================
+ Coverage 96.57% 96.65% +0.07%
==========================================
Files 15 15
Lines 1899 1914 +15
==========================================
+ Hits 1834 1850 +16
+ Misses 65 64 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the restriction against private properties. By default, these properties are undocumented, but they may be added to the docs with the
_doc_private = Trueclass attribute.This PR also slightly modifies
_doc_order- this attribute is now kept on the class and may be used for subclasses if their properties do not change.