Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow setting dynamic properties on init #187

Merged
merged 7 commits into from
Aug 10, 2017
Merged

Conversation

fwkoch
Copy link
Contributor

@fwkoch fwkoch commented Jul 26, 2017

No description provided.

@codecov
Copy link

codecov bot commented Jul 26, 2017

Codecov Report

Merging #187 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #187      +/-   ##
=========================================
+ Coverage   96.6%   96.61%   +0.01%     
=========================================
  Files         15       15              
  Lines       1883     1889       +6     
=========================================
+ Hits        1819     1825       +6     
  Misses        64       64
Impacted Files Coverage Δ
properties/basic.py 97.26% <100%> (+0.01%) ⬆️
properties/base/base.py 98.35% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f7f517...eb944e9. Read the comment docs.

@fwkoch fwkoch merged commit c72648e into dev Aug 10, 2017
@fwkoch fwkoch deleted the feat/no_dynamic_on_init branch August 10, 2017 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant