-
Notifications
You must be signed in to change notification settings - Fork 256
Update player.py and team.py #110
base: master
Are you sure you want to change the base?
Conversation
I have found 24 endpoints from stats.nba.com that are not currently included in nba_py Here are first 6 new endpoints in 6 new classes that can hopefully be added to the master repo I'm quite new to Python and GitHub so please let me know if I'm doing anything wrong, but hopefully I did enough testing on these classes before committing.
Fixed Travis CI suggestions
the 'Travis CI' check timed out after 10 minutes. Travis CI's documentation does not seem to offer any reason why this has occurred, but I notice that it's happened to previous commits. |
The IP addresses Travis uses are blocked by nba.com #88 |
Added some parameters that aren't required but can be provided anyway
What are the future plans for this project if the tests don't pass? I'm willing and able to take on some of the monitoring of some of this stuff. @seemethere |
Thanks @rneu31, it does seem a little quiet around here! I could help out if you need. Is nba_py used by reddit.com/r/nba or any other websites? Do we have a list of websites that make use of the repo? I'm interested to find out more, it would be good to know contributions are going to be put to use. |
Team hustle stats! Two new endpoints with their classes: TeamHustleLeaders (endpoint: leaguehustlestatsteamleaders) and TeamHustleStats (endpoint: leaguehustlestatsteam)
Player hustle stats added! 10 of 24 new endpoints now added (if you include teams.py). In this update: Two new endpoints with their classes: PlayerHustleLeaders (endpoint: leaguehustlestatsplayerleaders) and PlayerHustleStats (endpoint: leaguehustlestatsplayer)
fixed Travis CI whitespace issues and added call to _api_scrape inside TeamHustleStats
Travis CI whitespace issues fixed
I'm also willing to contribute. |
If anybody else wants to help me out with these new 'endpoints', here are the endpoints I found that I'm yet to write up: winprobabilitypbp |
Hi @inoble , I am taking a stab at adding the endpoints you found. I'm curious, how did you find these? Also a question for you and anyone else watching this thread, any advice for decoding some of these variables? For example, endpoint winprobabilitypbp requires variable runtype which I have no idea what it does or what options are available. |
Hi @inoble, I may have some free time this upcoming week. I’m open to
helping out where I can.
|
I’ve added features for leaguedashoppptshot already. I can merge my branch
soon.
|
@mneedham91 I stalked @seemethere's reddit comments and saw that he found the original 'endpoints' by checking a javascript file on nba.com. So I did the same and extracted all the endpoints. The problem is I can't find it anymore! I just had a pretty good look again and had no luck. |
@inoble How's it coming with those endpoints? Anything you need help with? |
@BenikaH - I've not been working on this any further since February. The endpoints that still need coding are: winprobabilitypbp I might come back to this in the coming months because I might be trying to code my own simulation engine now that my sim league (dynastyfive.com) is ready to start its off season, but I can't guarantee it. |
I have found 24 endpoints from stats.nba.com that are not currently included in nba_py
Here are the first 6 new endpoints in 6 new classes that can hopefully be added to the master repo
I'm quite new to Python and GitHub so please let me know if I'm doing anything wrong, but hopefully I did enough testing on these classes before committing.