fix: update app resource APIs to accept void*
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function signatures for the C store/load app resources APIs accept a `void*` for the `data` parameter. However, the Python language bindings were passing an array of bytes without performing casting. This resulted in a `TypeError` exception being raised. Signed-off-by: Michael Mead <mmead.developer@gmail.com>
|
The call is missing the data_size. seekcamera_load_app_resources_cdll.seekcamera_load_app_resources.restype = ctypes.c_int32 After I fixed this and used the enums instead of 0, 1, and 2 for the regions (the enums are 11, 12, and 13:0) it worked! |
tmullanix
reviewed
Jun 2, 2022
The C API `seekcamera_load_app_resources` takes a `data_size` parameter to indicate the size of the input buffer. Signed-off-by: Michael Mead <mmead.developer@gmail.com>
tmullanix
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function signatures for the C store/load app resources APIs
accept a
void*for thedataparameter. However, the Python languagebindings were passing an array of bytes without performing casting.
This resulted in a
TypeErrorexception being raised.Signed-off-by: Michael Mead mmead.developer@gmail.com