Skip to content

Commit

Permalink
Use SSH scheme in repository URLs (#955)
Browse files Browse the repository at this point in the history
Co-authored-by: Nik Skoufis <nskoufis@seek.com.au>
  • Loading branch information
72636c and Niksko committed Sep 10, 2022
1 parent 50b1dca commit 5743443
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 5 deletions.
7 changes: 7 additions & 0 deletions .changeset/gentle-rules-provide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'skuba': patch
---

template/\*-npm-package: Use SSH scheme in repository URL

We have changed the `package.json#repository/url` format from `git+https://github.com/org/repo.git` to `git+ssh://git@github.com/org/repo.git`. This may resolve `skuba release` errors that reference [Git password authentication is shutting down](https://github.blog/changelog/2021-08-12-git-password-authentication-is-shutting-down/) on the GitHub Blog.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/seek-oss/skuba.git"
"url": "git+ssh://git@github.com/seek-oss/skuba.git"
},
"resolutions": {
"**/@types/node": ">=14.18"
Expand Down
4 changes: 2 additions & 2 deletions src/utils/copy.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ describe('createEjsRenderer', () => {
const input = {
name: '<%- packageName %>',
repository: {
url: 'git+https://github.com/<%- orgName %>/<%- repoName %>.git',
url: 'git+ssh://git@github.com/<%- orgName %>/<%- repoName %>.git',
},
};

Expand All @@ -22,7 +22,7 @@ describe('createEjsRenderer', () => {
expect(JSON.parse(output)).toEqual({
name: 'seek-koala',
repository: {
url: 'git+https://github.com/seek-oss/koala.git',
url: 'git+ssh://git@github.com/seek-oss/koala.git',
},
});
});
Expand Down
2 changes: 1 addition & 1 deletion template/oss-npm-package/_package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"name": "<%- moduleName %>",
"repository": {
"type": "git",
"url": "git+https://github.com/<%- orgName %>/<%- repoName %>.git"
"url": "git+ssh://git@github.com/<%- orgName %>/<%- repoName %>.git"
},
"scripts": {
"build": "skuba build-package",
Expand Down
2 changes: 1 addition & 1 deletion template/private-npm-package/_package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"name": "<%- moduleName %>",
"repository": {
"type": "git",
"url": "git+https://github.com/<%- orgName %>/<%- repoName %>.git"
"url": "git+ssh://git@github.com/<%- orgName %>/<%- repoName %>.git"
},
"scripts": {
"build": "skuba build-package",
Expand Down

0 comments on commit 5743443

Please sign in to comment.