Fix CI (#962)

.changeset/red-apples-sell.md

@@ -0,0 +1,21 @@
+---
+'skuba': patch
+---
+
+deps: Drop `package-json`
+
+This circumvents the [following TypeScript compilation error](https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/62111) on a clean install:
+
+```console
+Error: node_modules/@types/cacheable-request/index.d.ts(0,0): error TS2709: Cannot use namespace 'ResponseLike' as a type.
+```
+
+If you run into this issue elsewhere in your project, you can temporarily work around it with a [resolution](https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/) in your `package.json`:
+
+```json
+{
+  "resolutions": {
+    "@types/responselike": "1.0.0"
+  }
+}
+```

package.json

@@ -34,7 +34,6 @@
     "normalize-package-data": "^4.0.0",
     "npm-run-path": "^4.0.1",
     "npm-which": "^3.0.1",
-    "package-json": "^7.0.0",
     "picomatch": "^2.2.2",
     "prettier": "~2.7.0",
     "read-pkg-up": "^7.0.1",
@@ -50,7 +49,8 @@
     "ts-node-dev": "^2.0.0",
     "tsconfig-paths": "^4.0.0",
     "tsconfig-seek": "1.0.2",
-    "typescript": "~4.8.2"
+    "typescript": "~4.8.2",
+    "validate-npm-package-name": "^4.0.0"
   },
   "description": "SEEK development toolkit for backend applications and packages",
   "devDependencies": {
@@ -66,6 +66,7 @@
     "@types/npm-which": "3.0.1",
     "@types/picomatch": "2.3.0",
     "@types/supertest": "2.0.12",
+    "@types/validate-npm-package-name": "4.0.0",
     "enhanced-resolve": "5.10.0",
     "express": "4.18.1",
     "jsonfile": "6.1.0",

src/utils/version.ts

@@ -1,15 +1,45 @@
-import packageJson from 'package-json';
+import path from 'path';
+
+import validatePackageName from 'validate-npm-package-name';
 
 import { getSkubaManifest } from './manifest';
+import { isObject } from './validation';
 import { withTimeout } from './wait';
 
+const loadPackageJson = async (
+  packageName: string,
+): Promise<Record<string, unknown>> => {
+  const { validForNewPackages } = validatePackageName(packageName);
+
+  if (!validForNewPackages) {
+    throw new Error(`Package "${packageName}" does not have a valid name`);
+  }
+
+  const message = `Package "${packageName}" does not have a valid package.json manifest`;
+
+  let packageJson: unknown;
+  try {
+    packageJson = await import(path.posix.join(packageName, 'package.json'));
+  } catch {
+    throw new Error(message);
+  }
+
+  if (!isObject(packageJson)) {
+    throw new Error(message);
+  }
+
+  return packageJson;
+};
+
 export const latestNpmVersion = async (
   packageName: string,
 ): Promise<string> => {
-  const { version } = await packageJson(packageName);
+  const { version } = await loadPackageJson(packageName);
 
   if (typeof version !== 'string') {
-    throw new Error(`No version found for package "${packageName}"`);
+    throw new Error(
+      `Package "${packageName}" does not have a valid version in its package.json manifest`,
+    );
   }
 
   return version;

template/lambda-sqs-worker/package.json

@@ -23,6 +23,9 @@
   },
   "license": "UNLICENSED",
   "private": true,
+  "resolutions": {
+    "@types/responselike": "1.0.0"
+  },
   "scripts": {
     "build": "skuba build",
     "deploy": "serverless deploy --force --verbose",