Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: skuba 7.3.0 #216

Merged
merged 1 commit into from
Nov 2, 2023
Merged

deps: skuba 7.3.0 #216

merged 1 commit into from
Nov 2, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 2, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
skuba 7.2.0 -> 7.3.0 age adoption passing confidence

Release Notes

seek-oss/skuba (skuba)

v7.3.0

Compare Source

Minor Changes
  • Jest.mergePreset: Propagate root-level configuration options to projects (#​1294)

    Jest.mergePreset now propagates the moduleNameMapper and transform options from root-level configuration to the projects array.

    If you were referencing the base config in the projects array:

    const baseConfig = Jest.mergePreset({
      // ...
    });
    
    export default {
      ...baseConfig,
      projects: [
        {
          ...baseConfig,
          displayName: 'unit',
          setupFiles: ['<rootDir>/jest.setup.ts'],
          testPathIgnorePatterns: ['\\.int\\.test\\.ts'],
        },
        {
          ...baseConfig,
          displayName: 'integration',
          setupFiles: ['<rootDir>/jest.setup.ts'],
          testMatch: ['**/*.int.test.ts'],
        },
      ],
    };

    You can replace it with the following:

    export default Jest.mergePreset({
      // ...
      projects: [
        {
          displayName: 'unit',
          setupFiles: ['<rootDir>/jest.setup.ts'],
          testPathIgnorePatterns: ['\\.int\\.test\\.ts'],
        },
        {
          displayName: 'integration',
          setupFiles: ['<rootDir>/jest.setup.ts'],
          testMatch: ['**/*.int.test.ts'],
        },
      ],
    });

    The projects option allows you to reuse a single Jest config file for different test types. View the Jest documentation for more information.

  • Net.waitFor: Use Docker Compose V2 (#​1281)

    This function now executes docker compose under the hood as docker-compose stopped receiving updates in July 2023. See the Docker manual for more information.

  • lint: Add prettier-plugin-packagejson (#​1276)

    This Prettier plugin sorts and formats your package.json file.

Patch Changes
  • Git: Handle non-root working directories in commitAllChanges (#​1269)

  • template/koa-rest-api: Fix app.test.ts assertions (#​1282)

    Previously, custom .expect((res) => {}) assertions were incorrectly defined to return false rather than throw an error. The template has been updated to avoid this syntax, but the most straightforward diff to demonstrate the fix is as follows:

    - await agent.get('/').expect(({ status }) => status !== 404);
    + await agent.get('/').expect(({ status }) => expect(status).not.toBe(404));
  • template: seek-oss/docker-ecr-cache 2.1 (#​1266)

    This update brings a new skip-pull-from-cache option which is useful on Warm/Build Cache steps.

    At SEEK, our build agents no longer persist their Docker build cache from previous steps. This option allows a preparatory step to proceed on a cache hit without pulling the image from ECR, which can save on average ~1 minute per build for a 2GB Docker image.

  • lint: Resolve infinite autofix loop (#​1262)

  • GitHub: Add working directory parameter to readFileChanges (#​1269)

    The input ChangedFiles need to be evaluated against a working directory. While this is technically a breaking change, we have not found any external usage of the function in SEEK-Jobs.

    - GitHub.readFileChanges(changedFiles)
    + GitHub.readFileChanges(dir, changedFiles)
  • lint: Handle non-root working directories in autofix commits (#​1269)

    Previously, skuba lint could produce surprising autofix commits if it was invoked in a directory other than the Git root. Now, it correctly evaluates its working directory in relation to the Git root, and will only commit file changes within its working directory.

  • cli: Migrate from Runtypes to Zod (#​1288)

    The skuba CLI now uses Zod internally. This should not result in noticeable differences for consumers.

  • template: Mount npm build secret to a separate directory (#​1278)

    Our templated Buildkite pipelines currently retrieve a temporary .npmrc. This file contains an npm read token that allows us to fetch private @seek-scoped packages.

    New projects now write this file to /tmp/ on the Buildkite agent and mount it as a secret to /root/ in Docker. This separation allows you to commit a non-sensitive .npmrc to your GitHub repository while avoiding accidental exposure of the npm read token. This is especially important if you are migrating a project to pnpm, which houses some of its configuration options in .npmrc.

    Existing projects are generally advised to wait until we've paved a cleaner migration path for pnpm.


Configuration

📅 Schedule: Branch creation - "after 3:00 am and before 6:00 am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@72636c 72636c merged commit 34b50eb into master Nov 2, 2023
6 checks passed
@72636c 72636c deleted the renovate-skuba-7.x branch November 2, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant