Skip to content

UpdateEl refactor + updates #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

MartinKavik
Copy link
Member

@MartinKavik MartinKavik commented Feb 27, 2020

Resolves #370.
Resolves #365.
Resolves #128.

Changelog:

  • [BREAKING] UpdateEl<T> changed to UpdateEl<Ms> and fn update(self, el: &mut T); to fn update_el(self, el: &mut El<Ms>);.
  • Added trait UpdateElForIterator<Ms>.
  • Added support for all Iterators, Option, u32, i32, usize, f64 and references in element creation macros.

@MartinKavik
Copy link
Member Author

cc @TatriX @rebo

@rebo
Copy link
Collaborator

rebo commented Feb 29, 2020

Code read through looks good. Covers all latest issues.

I need to test but what is the error if a user doesn't use a reference in say &model.title which is now needed as this will be a common user error.

I assume rust suggests adding the & so all good.

@MartinKavik
Copy link
Member Author

MartinKavik commented Feb 29, 2020 via email

@rebo
Copy link
Collaborator

rebo commented Feb 29, 2020

Yep I think it's definitely needed just have to manage the expected compiler errors when users try without a reference.

@MartinKavik MartinKavik merged commit 6670631 into seed-rs:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seed's UpdateEl::update method clashes with Itertools Add More impls for UpdateEl .. Implement UpdateEl for iterators
2 participants