New Fetch API #353
Closed
New Fetch API #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TatriX
force-pushed
the
feat/fetch
branch
4 times, most recently
from
d49962d to
480537c
Compare
MartinKavik
reviewed
Feb 19, 2020
TatriX
force-pushed
the
feat/fetch
branch
4 times, most recently
from
ea6dacb to
3f7c1a7
Compare
rebo
reviewed
Mar 4, 2020
| //! | ||
| //! There is one entry point: [`fetch`][fetch] function. | ||
| //! It can accept both, String urls as well as [`Request`][request]. | ||
| //! It can accept both, string urls as well as [`Request`][request]. |
There was a problem hiding this comment.
Minor grammar quibble, no comma needed after "... accept both, "
MartinKavik
reviewed
Mar 4, 2020
|
|
||
| let token = "YWxhZGRpbjpvcGVuc2VzYW1l"; | ||
| // Created outside async block because of lifetime reasons | ||
| // (we can't use reference to `model.from` in async |
There was a problem hiding this comment.
Suggested change
| // (we can't use reference to `model.from` in async | |
| // (we can't use reference to `model.form` in async |
MartinKavik
reviewed
Mar 4, 2020
| let token = "YWxhZGRpbjpvcGVuc2VzYW1l"; | ||
| // Created outside async block because of lifetime reasons | ||
| // (we can't use reference to `model.from` in async | ||
| // function). |
There was a problem hiding this comment.
Is it on the standalone line because of GitHub weird line breaks or Rust formatter?
So user can easily use `future.map` and `future.and_then`
|
Closing in favor of PR #402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.