Port to Vim9 script #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `s:` form was supported in beta but not in released Vim 9.
|
Oh hey, that's really cool! Not sure whether or not I'll merge it, but I will certainly try it out and consider it: I was curious as to whether Vim9 script's performance improvements would have much effect on this plugin, and it would be nice if the timing values affected the actual behaviour a bit more predictably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love this plugin, and took a quick stab at porting it to Vim9. It worked out well (after some trial and error), and since Vim9 is so heavily optimized, the rainbow got even more blazingly fast for free.
I open this as a PR, but I fully understand and respect that you support both Vim and NeoVim, and that this might not be merged at all. Think of this as much as a "thank you" in code, and hopefully as inspiration. I will in no way be offended if you close with WONTFIX.
(I also recommend to do the porting exercise for anyone to get to know both your plugin and Vim9 script.)