Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce multi-stage build, actually build our code #31

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

SequeI
Copy link
Collaborator

@SequeI SequeI commented Sep 3, 2024

No description provided.

@bkabrda
Copy link

bkabrda commented Sep 4, 2024

Let's do the same in Dockerfile.tuffer as well.

@bkabrda
Copy link

bkabrda commented Sep 4, 2024

I also found out that this produces an image with size ~16 GB. The problem is in keeping the whole target/ directory (14 GB) produced by cargo build - it should be safe to remove it after the build to save up space.

Edit: prior to that, target/release/tuftool has to be copied to /usr/bin/ to actually be usable.
Edit 2: one more nit - it might be good to copy into a new directory in e.g. /tmp. Right now the files get copied to container root, which could pollute things in an unexpected way.

@bkabrda bkabrda changed the title adding tuftool build in dockerfile Introduce multi-stage build, actually build our code Sep 4, 2024
Copy link

@fghanmi fghanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fghanmi, SequeI

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bkabrda bkabrda merged commit 6ead471 into develop Sep 4, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants