Fix serialization in GPGSignature and formatting #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPG signature requires `sig` on load but dumps `signature` key in a dict which should be the same key name secure-systems-lab#418. Some formatting fixes are made to the singer.py. Signed-off-by: Pradyumna Krishna <git@onpy.in>
|
@PradyumnaKrishna, I appreciate that you are auto-formatting these relatively new modules. In the future, I'd welcome a separate commit for them. That would make review easier. |
|
Great job catching that issue! |
Next time I will keep that in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #418
Description of the changes being introduced by the pull request:
GPG signature requires
sigon load but dumpssignaturekey in a dict which should be the same key name.This pull request aims to fix that issue. Test case is added to ensure this will not happen in future.
Some formatting fixes are made to the
singer.py.Please verify and check that the pull request fulfils the following requirements: