Add nistp384 signature verification support #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support nistp384 in addition to nistp256 in ECDSA signing scheme and key formats, required for PEP458. This commit also removes the related but obsolete REQUIRED_LIBRARIES_SCHEMA, which was only used in the long-gone check_crypto_libraries tuf function. Note: This commit tries to blend in with the current sslib design. I future work we should: - define securesystemslib-wide constants instead of hardcoding strings over and over again (see item 3 in secure-systems-lab#183) - re-think "key type" vs. "signature scheme"
This commit adds support for verifying ecdsa signature on the nistp384 curve with sha384 digests to the internal ecdsa_keys module. It does so by adding module global helper dictionary to map schemes to hash algorithms. Note: This commit tries to blend in with the current sslib design. In future work we should: - define securesystemslib-wide constants instead of hardcoding strings over and over again (see item 3 in secure-systems-lab#183)
Support nistp384 in addition to nistp256 in the public keys.verify_signature interface. Note: This commit tries to blend in with the current sslib design. In future work we should: - define securesystemslib-wide constants instead of hardcoding strings over and over again (see item 3 in secure-systems-lab#183) - re-think "key type" vs. "signature scheme"
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
Required for PEP 458
Description of the changes being introduced by the pull request:
keysand internalecdsa_keysmodules to support verification of nistp384 signatures.Testing will be added in a subsequent PR that adds HSM signing and pubkey export functionality.
Please verify and check that the pull request fulfils the following
requirements: