Add default keyid to format_metadata_to_key #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aller to provide a default keyid. This will help remove the depenency on keyid_hash_algorithms in tuf while remaining backwards compatible
joshuagl
reviewed
Apr 3, 2020
| @@ -474,7 +474,7 @@ def format_keyval_to_metadata(keytype, scheme, key_value, private=False): | |||
|
|
|||
|
|
|||
|
|
|||
| def format_metadata_to_key(key_metadata): | |||
| def format_metadata_to_key(key_metadata, default_keyid=None): | |||
There was a problem hiding this comment.
Could you document default_keyid in the Arguments section of the docstring?
Co-Authored-By: Joshua Lock <jlock@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional parameter to format_metadata_to_key that allows the caller to provide a default keyid. This change can be used for future changes that remove keyid_hash_algorithms from TUF as described in theupdateframework/python-tuf#848.