Reorganize DSSE library #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adityasaky
commented
Apr 30, 2023
adityasaky
commented
- Reorganizes source files
- Removes Verify method from EnvelopeSigner -> use EnvelopeVerifier directly -- happy to reverse this if needed
- Renames SignVerifier to SignerVerifier (with an alias for compatibility)
* Reorganizes source files * Removes Verify method from EnvelopeSigner -> use EnvelopeVerifier directly * Renames SignVerifier to SignerVerifier (with an alias for compatibility) Signed-off-by: Aditya Sirish <aditya@saky.in>
pxp928
approved these changes
May 1, 2023
|
|
||
| // SignerVerifer provides both the signing and verification interface. | ||
| type SignerVerifier interface { | ||
| Signer |
There was a problem hiding this comment.
could consolidate the Signer and Verifier interface here.
There was a problem hiding this comment.
Do you mean move Signer and Verifier in here as well and have only the EnvelopeSigner and EnvelopeVerifier implementations in sign.go and verify.go?
There was a problem hiding this comment.
Did that in a separate commit.
Signed-off-by: Aditya Sirish <aditya@saky.in>
* Consolidate Signer and Verifier interfaces in signerverifier.go * Move verification tests to verify_test.go * Rename interceptSigner Signed-off-by: Aditya Sirish <aditya@saky.in>
|
Should we loop someone in on removing |
Signed-off-by: Aditya Sirish <aditya@saky.in>
|
I'm merging this for now so we can test this and #43 with in-toto-golang via the commits. We can cut a release later and decide if we want to add the Verify interface back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.