Skip to content

Fix interproc constant folding with side-effects #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

t1mlange
Copy link
Contributor

There's no guarantee that the constant folding actually folds in the inserted assign.

@StevenArzt
Copy link
Member

StevenArzt commented May 14, 2025

In most cases, the resulting Jimple code should still be the same because we run a DeadCodeEliminator over the simplified Jimple bodies in the end if I am not mistaken. So just not removing the assignment here should be the safest option.

@StevenArzt StevenArzt merged commit 2227456 into secure-software-engineering:develop May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants