-
Notifications
You must be signed in to change notification settings - Fork 6
Generalize the scopes to make them more consistent #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
boomerangScope-Soot/src/main/java/boomerang/scope/soot/SootCallGraph.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work - I guess I would not have passed around the scene singleton for Soot as this will most likely never be anything else than a global singleton.
boomerangPDS/src/main/java/boomerang/poi/ExecuteImportFieldStmtPOI.java
Outdated
Show resolved
Hide resolved
@swissiety I added the suggested changes. I added the Scene object just to be consistent. It is also easier to document the scopes, e.g. "Each scope has a "master" object (Scene, View, Project) that is passed between the scope objects" |
With the addition of the Opal scope, we had to refactor some parts in the scope structure because it was optimized for Soot. This PR contains some more internal refactoring to make the scopes more consistent:
Close #130
Close #134