Skip to content

Generalize the scopes to make them more consistent #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 6, 2025

Conversation

smeyer198
Copy link
Collaborator

@smeyer198 smeyer198 commented Apr 28, 2025

With the addition of the Opal scope, we had to refactor some parts in the scope structure because it was optimized for Soot. This PR contains some more internal refactoring to make the scopes more consistent:

Close #130
Close #134

@smeyer198 smeyer198 marked this pull request as ready for review April 30, 2025 10:20
Copy link
Member

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work - I guess I would not have passed around the scene singleton for Soot as this will most likely never be anything else than a global singleton.

@smeyer198
Copy link
Collaborator Author

@swissiety I added the suggested changes. I added the Scene object just to be consistent. It is also easier to document the scopes, e.g. "Each scope has a "master" object (Scene, View, Project) that is passed between the scope objects"

@swissiety swissiety enabled auto-merge May 6, 2025 14:07
@swissiety swissiety merged commit a4a5aa1 into develop May 6, 2025
4 checks passed
@swissiety swissiety deleted the feature/scope-genralization branch May 6, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phantom Field Resolution Requires Full Library Inclusion While Seed Generation Ignores It check handling of "PhantomFields" in BoomerangScope-SootUp
3 participants