updated name of function in the GameFormHelpers

secure-delivery · Jul 10, 2024 · 3d39957 · 3d39957
1 parent 1c9fd71
commit 3d39957
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/lib/copi_web/live/game_live/create_game_form.ex b/lib/copi_web/live/game_live/create_game_form.ex
@@ -50,7 +50,7 @@ defmodule CopiWeb.GameLive.CreateGameForm do
       Cornucopia.change_game(%Game{
         edition: "",
         name: "",
-        suits: GameFormHelpers.generate_displayable_suits_from_suits_tuple_list("webapp")
+        suits: GameFormHelpers.generate_suit_list_formatted_for_checkbox("webapp")
       })
 
     {:ok,
@@ -67,7 +67,7 @@ defmodule CopiWeb.GameLive.CreateGameForm do
       |> Cornucopia.change_game(%{
         edition: game_params["edition"],
         name: game_params["name"],
-        suits: GameFormHelpers.display_correct_suit_list(game_params["edition"], game_params["suits"])
+        suits: GameFormHelpers.display_appropriate_suits_list(game_params["edition"], game_params["suits"])
       })
       |> Map.put(:action, :validate)
 

diff --git a/lib/copi_web/live/game_live/game_form_helpers.ex b/lib/copi_web/live/game_live/game_form_helpers.ex
@@ -4,7 +4,7 @@ defmodule CopiWeb.GameLive.GameFormHelpers do
   alias Copi.Cornucopia.Game
   alias Copi.Games
 
-  def generate_displayable_suits_from_suits_tuple_list(edition) do
+  def generate_suit_list_formatted_for_checkbox(edition) do
     format_list_of_suits_for_checkbox(edition)
     |> Enum.map(fn {key, _} -> key end)
   end
@@ -23,15 +23,15 @@ defmodule CopiWeb.GameLive.GameFormHelpers do
     |> Enum.map(fn suit -> {"#{selected_edition}-#{suit}" , String.capitalize(suit) } end)
   end
 
-  def display_correct_suit_list(edition, suits) do
+  def display_appropriate_suits_list(edition, suits) do
     if hd(suits) == "" && length(suits) == 1 do
-      generate_displayable_suits_from_suits_tuple_list(edition)
+      generate_suit_list_formatted_for_checkbox(edition)
     else
       [_first, second | _rest] = suits
       String.contains?(second, edition)
       case String.contains?(second, edition) do
         true -> suits
-        false -> generate_displayable_suits_from_suits_tuple_list(edition)
+        false -> generate_suit_list_formatted_for_checkbox(edition)
       end
     end
   end

diff --git a/test/copi_web/live/page_live_test.exs b/test/copi_web/live/page_live_test.exs
@@ -7,6 +7,6 @@ defmodule CopiWeb.PageLiveTest do
   test "disconnected and connected render", %{conn: conn} do
     {:ok, page_live, disconnected_html} = live(conn, "/")
     assert disconnected_html =~ "Welcome to Phoenix!"
-    assert render(page_live) =~ "Welcome to Phoenix!"
+    assert render(page_live) = "Welcome to Phoenix!"
   end
 end