Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #641 #643

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[FIX] #641 #643

merged 1 commit into from
Apr 8, 2024

Conversation

fionser
Copy link
Collaborator

@fionser fionser commented Apr 8, 2024

Pull Request

What problem does this PR solve?

Issue Number: Fixed #641

Possible side effects?

  • Performance:

  • Backward compatibility:

@fionser
Copy link
Collaborator Author

fionser commented Apr 8, 2024

Actually, the fixed branch is a "dead' code for SPU, since it is never called from SPU.

Copy link
Collaborator

@anakinxc anakinxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakinxc anakinxc merged commit 8961e7d into secretflow:main Apr 8, 2024
9 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: One more minus sign
2 participants