chore: use clang-format 19 #1085
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @tongke6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request seems to be a minor cleanup. It involves changes to src/libspu/core/half.h, src/libspu/core/parallel_utils.h, src/libspu/mpc/api_test.cc, and src/libspu/spu.h. The changes primarily focus on formatting and code style improvements, such as removing extra spaces and aligning code for better readability. There's no description body provided, so I'm inferring the intent from the changes themselves.
Highlights
- Formatting: The majority of changes involve minor formatting adjustments, such as removing extra spaces and aligning code elements.
- Readability: The changes aim to improve the overall readability and maintainability of the codebase.
Changelog
- src/libspu/core/half.h
- Removed extra spaces in template declarations for
float2halfandhalf2floatfunctions.
- Removed extra spaces in template declarations for
- src/libspu/core/parallel_utils.h
- Removed an extra newline in the
pforeachtemplate declaration.
- Removed an extra newline in the
- src/libspu/mpc/api_test.cc
- Removed an extra space in the
TEST_UNARY_OP(not )macro call.
- Removed an extra space in the
- src/libspu/spu.h
- Removed curly braces after the constructor in
RuntimeConfig.
- Removed curly braces after the constructor in
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is the primary purpose of clang-format?
Click here for the answer
The primary purpose of clang-format is to automatically format C, C++, Objective-C, Java, JavaScript, TypeScript, Protocol Buffers, and CUDA code, according to a style guide.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the clang-format version used in the project. The changes primarily involve reformatting code to adhere to the new clang-format version's style guidelines. Overall, the changes seem straightforward and address the intended goal.
Summary of Findings
- Spacing around template parameters: The changes introduce spacing between the
bool_typetemplate name and the angle brackets, which might affect readability. While clang-format enforces this, it's worth considering if it improves or detracts from the code's clarity. - Spacing in initializer lists: The changes introduce spacing in initializer lists, which might affect readability. While clang-format enforces this, it's worth considering if it improves or detracts from the code's clarity.
- Spacing after
notkeyword: The changes remove the space after thenotkeyword in a test case. This is a minor stylistic change but contributes to consistency.
Merge Readiness
The pull request appears to be in good shape for merging. The changes are primarily stylistic, driven by the clang-format update. Since there are no critical or high severity issues, the pull request is likely ready to be merged after addressing the medium severity comments. However, I am unable to approve the pull request, and users should have others review and approve this code before merging.
No description provided.