chore: use clang-format 19 #1084
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @tongke6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the gRPC dependency to version 1.66.0.bcr.4 and removes associated patches. It also updates various Bazel module dependencies in the MODULE.bazel.lock files for both the root and src directories. The changes involve updating the gRPC dependency and updating/adding other dependencies such as abseil-cpp, boringssl, gazelle, re2, rules_go, and upb in the lock files. Additionally, there are minor code style fixes in src/libspu/core/half.h and src/libspu/core/parallel_utils.h, and a typo fix in src/libspu/mpc/api_test.cc. A redundant semicolon is removed in src/spu.h.
Highlights
- gRPC Dependency Update: The gRPC dependency is updated to version 1.66.0.bcr.4, and the associated patches are removed.
- Bazel Module Lockfile Updates: The
MODULE.bazel.lockfiles in both the root andsrcdirectories are updated to reflect changes in various module dependencies. - Code Style and Typo Fixes: Minor code style fixes are applied to
src/libspu/core/half.handsrc/libspu/core/parallel_utils.h, and a typo is corrected insrc/libspu/mpc/api_test.cc.
Changelog
Click here to see the changelog
- MODULE.bazel
- Updated gRPC dependency to version 1.66.0.bcr.4
- Removed gRPC related patches
- MODULE.bazel.lock
- Updated various Bazel module dependencies including abseil-cpp, boringssl, gazelle, re2, rules_go, and upb.
- bazel/patches/grpc-1.66.patch
- Removed patch file.
- bazel/patches/grpc-module-file.patch
- Removed patch file.
- src/MODULE.bazel
- Updated gRPC dependency to version 1.66.0.bcr.4
- Removed gRPC related patches
- src/MODULE.bazel.lock
- Updated various Bazel module dependencies including abseil-cpp, boringssl, gazelle, re2, rules_go, and upb.
- src/libspu/core/half.h
- Fixed code style in template declaration.
- src/libspu/core/parallel_utils.h
- Fixed code style in template declaration.
- src/libspu/mpc/api_test.cc
- Fixed typo in TEST_UNARY_OP macro.
- src/spu.h
- Removed redundant semicolon in RuntimeConfig struct.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
gRPC, initially developed at Google, stands for gRPC Remote Procedure Calls. The 'g' doesn't actually stand for anything!
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the clang-format version and updates dependencies in the bazel files. The changes seem straightforward, but it's important to ensure that the dependency updates are compatible and that the removal of patches is justified.
Summary of Findings
- Missing patches: The removal of patches in
MODULE.bazelandsrc/MODULE.bazelwithout corresponding updates to the codebase or justification raises concerns. It's crucial to understand why these patches are no longer needed and ensure that the functionality they provided is still maintained or has been superseded by other mechanisms. - Inconsistent dependency versions: The
MODULE.bazel.lockfile shows numerous updates to dependency versions. While updating dependencies is a good practice, it's important to verify that these updates are compatible with the project and don't introduce any regressions or breaking changes. A thorough testing strategy should be in place to validate these updates.
Merge Readiness
The pull request updates the clang-format version and updates dependencies in the bazel files. However, there are some concerns about the removal of patches and the compatibility of dependency updates. I would recommend addressing these concerns before merging. At a minimum, the high severity issues should be addressed before merging. I am unable to directly approve this pull request, and other reviewers should also review and approve this code before merging.
No description provided.