-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] add faq issue doc in Chinese #1067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @521xueweihan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds Chinese translations to the documentation files docs/locales/zh_CN/LC_MESSAGES/getting_started/faq.po
and docs/locales/zh_CN/LC_MESSAGES/getting_started/issue.po
. The translations cover frequently asked questions and issue reporting guidelines, aiming to provide Chinese-speaking users with better access to the documentation.
Highlights
- Translation: Adds Chinese translations for FAQ documentation.
- Translation: Adds Chinese translations for issue reporting documentation.
Changelog
- docs/locales/zh_CN/LC_MESSAGES/getting_started/faq.po
- Translated FAQ content into Chinese, covering installation, usage, and general questions.
- Ensured accurate and contextually appropriate translations for technical terms and explanations.
- docs/locales/zh_CN/LC_MESSAGES/getting_started/issue.po
- Translated issue reporting guidelines into Chinese.
- Updated the 'Github Issues' link to 'GitHub Issues' and translated the surrounding text.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
From English to Chinese script,
Documentation gets a helpful lift.
FAQs and issues now clear,
For users far and near.
A language bridge, a thoughtful gift.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds Chinese translations for FAQ and issue reporting documentation. The changes seem straightforward and well-organized.
Summary of Findings
- Inconsistent terminology: The translation for 'Github Issues' is inconsistent between the two files. It's '
Github Issues
' infaq.po
and 'GitHub Issues
' inissue.po
. Consistency is important for user understanding.
Merge Readiness
The pull request appears to be ready for merging, pending resolution of the terminology inconsistency. There are no identified critical or high severity issues.
msgid "" | ||
"Please create an issue at `Github Issues " | ||
"Please create an issue at `GitHub Issues " | ||
"<https://github.com/secretflow/spu/issues>`_." | ||
msgstr "" | ||
|
||
msgstr "请创建一个 `GitHub Issues <https://github.com/secretflow/spu/issues>`_。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation for 'GitHub Issues' is '请创建一个 GitHub Issues <https://github.com/secretflow/spu/issues>
_。' This is good. However, in docs/locales/zh_CN/LC_MESSAGES/getting_started/faq.po
, the translation for 'Github Issues' is not translated. To ensure consistency, please use the same translation here.
msgstr "请创建一个 `GitHub Issues <https://github.com/secretflow/spu/issues>`_。"
msgid "Frequently Asked Questions (FAQ)" | ||
msgstr "" | ||
msgstr "常见问题(FAQ)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have read the CLA Document and I hereby sign the CLA |
|
check |
recheck |
Pull Request
What problem does this PR solve?
Issue Number: Fixed #1015
Possible side effects?
Performance:
Backward compatibility: