Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid recompiling training loss closure #553

Merged
merged 5 commits into from
May 13, 2022
Merged

Avoid recompiling training loss closure #553

merged 5 commits into from
May 13, 2022

Conversation

uri-granta
Copy link
Collaborator

@uri-granta uri-granta commented May 9, 2022 •
edited
Loading

Avoid regenerating a new closure every BO step by compiling and saving a single function.

Also avoid recompiling acquisition functions combined using a Product or other reducer.

@uri-granta uri-granta marked this pull request as ready for review May 10, 2022 10:07
@uri-granta uri-granta requested a review from hstojic May 10, 2022 10:10
hstojic
hstojic approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@hstojic hstojic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, but this code is beyond my skills, I'll trust you know what you are doing :)

@uri-granta uri-granta requested a review from henrymoss May 12, 2022 08:25
@uri-granta uri-granta merged commit 44b3e25 into develop May 13, 2022
@uri-granta uri-granta deleted the uri/avoid_recompiling_training_loss_function branch May 13, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hstojic hstojic hstojic approved these changes

@henrymoss henrymoss Awaiting requested review from henrymoss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uri-granta @hstojic