New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep ensemble trajectory sampler update #541

Merged

hstojic merged 39 commits into develop from hstojic/de_sampler_update

May 23, 2022

Collaborator

hstojic commented Apr 4, 2022 •

edited

Loading

with the parallel continuous thompson sampling trajectory samplers in gpflow were modified substantially, so now keras and gpflux trajectory samplers need to be updated as well, here is the one for deep ensembles

hstojic and others added 18 commits

March 31, 2022 19:05


          added integration test for parallel TS

89bb818


          working draft, no tests

39ec880


          fixing samples option

e587234


          another fix of the sampling mode


          Some suggestions to get this working

e8c073a


          reset_batch_size

f8833b2


          Revert

93c7699


          More

7d97009


          Start with mean approach

5cc0e4d


          More playing

bb2d4bc


          Format

642271d


          Use mixture distribution

50ee255


          Fix and use in test

6b59694


          Merge branch 'develop' into hstojic/de_sampler_update

5054f5c


          Merge remote-tracking branch 'origin/uri/de_sampler_suggestions' into…

62edb68

… hstojic/de_sampler_update


          Some suggestions to get this working (#546)

45b65bd


          Merge branch 'develop' into hstojic/de_sampler_update

66990e5


          cleaned docs; simplified model methods

bc8642b

hstojic marked this pull request as ready for review

May 4, 2022 10:13

uri-granta self-requested a review

May 5, 2022 12:57

hstojic added 2 commits

May 5, 2022 14:29


          update trajectory fixed; docs update

faa759a


          added more tests

cda17d3

hstojic commented

View reviewed changes

tests/unit/models/keras/test_sampler.py Show resolved Hide resolved

hstojic commented

View reviewed changes

tests/unit/models/keras/test_sampler.py Outdated Show resolved Hide resolved

hstojic commented

View reviewed changes

tests/unit/models/keras/test_sampler.py Outdated Show resolved Hide resolved

hstojic commented

View reviewed changes

tests/unit/models/keras/test_sampler.py Show resolved Hide resolved

hstojic commented

View reviewed changes

trieste/models/interfaces.py Outdated Show resolved Hide resolved

hstojic commented

View reviewed changes

trieste/models/keras/sampler.py Outdated Show resolved Hide resolved

hstojic added 2 commits

May 9, 2022 13:40


          using quantiles now

47df3d7


          updated the model to use quantiles

0dc4965

hstojic and others added 13 commits

May 9, 2022 23:15


          draft for multi-output

05b80c4


          testing ensemble_outputs

24124b0


          added test for resetting the learning rate


          simplified ensemblemodel interface

cfed4ea


          changed use_quantiles to diversify; using quantile fnc; returned samp…

1095a9d

…le_index; ensemble_outputs


          renamed vanilla builder

8a6645b


          almost all sorted out

eac9b03


          integration tests -failing atm

cf2d93c


          Merge branch 'develop' into hstojic/de_sampler_update

440b3c0


          Change test to check trajectories from same sampler (#552)

092db4d

Co-authored-by: Uri Granta <uri.granta@secondmind.io>
Co-authored-by: hstojic <hrvoje.stojic@protonmail.com>


          format; tests

640a639


          resolved conflicts

12eb84c


          formatting; typing

d37a5c5

uri-granta reviewed

View reviewed changes

Collaborator

uri-granta left a comment

Looks good! Just a couple of questions.

trieste/models/interfaces.py Outdated Show resolved Hide resolved

trieste/models/keras/architectures.py Outdated Show resolved Hide resolved

trieste/models/keras/architectures.py Show resolved Hide resolved

trieste/models/keras/models.py Outdated Show resolved Hide resolved

tests/unit/models/keras/test_utils.py Show resolved Hide resolved

tests/unit/models/keras/test_sampler.py Outdated Show resolved Hide resolved

tests/integration/test_bayesian_optimization.py Outdated Show resolved Hide resolved


          addressed comments; fixed integration tests

0ae3892

hstojic requested a review from uri-granta

May 19, 2022 23:43

uri-granta reviewed

View reviewed changes

tests/unit/models/keras/test_sampler.py Outdated Show resolved Hide resolved

tests/unit/models/keras/test_sampler.py Outdated Show resolved Hide resolved

uri-granta approved these changes

View reviewed changes

Collaborator

uri-granta left a comment

Looks good! Happy to help you look at the failing test if you want.

hstojic and others added 3 commits

May 20, 2022 11:49


          attempt at fixing a test due to seeds

96dec34


          random seed now working but typing failing

694667c


          Fix typing for random_seed decorator (#562)

cb7aaff

Co-authored-by: Uri Granta <uri.granta@secondmind.ai>

hstojic merged commit 372b1b1 into develop

hstojic deleted the hstojic/de_sampler_update branch

May 23, 2022 13:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet