Henry/wallclock #488
Merged
Henry/wallclock #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2022 17:59
uri-granta
approved these changes
Feb 2, 2022
vpicheny
reviewed
Feb 2, 2022
Mentioned it in the logging notebook |
uri-granta
reviewed
Feb 3, 2022
apaleyes
approved these changes
Feb 3, 2022
trieste/bayesian_optimizer.py
Outdated
Comment on lines
459
to
465
| with timeit() as total_wallclock_timer: | ||
| if step == 0 and fit_initial_model: | ||
| with timeit() as initial_model_fitting_timer: | ||
| for tag, model in models.items(): | ||
| dataset = datasets[tag] | ||
| model.update(dataset) | ||
| model.optimize(dataset) |
There was a problem hiding this comment.
That looks like way too many levels of nesting, but i don't have a good alternative. @uri-granta any ideas?
There was a problem hiding this comment.
I think it's fine (though I used to write LISP code so maybe I'm not scared of nesting as much as I should be)
There was a problem hiding this comment.
this method overall looks pretty scary to me. half-way through it's hard to figure out at which level you are
added 2 commits
February 3, 2022 09:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @apaleyes and @vpicheny , I have added in some wallclock timing to our Tensorboard logging.
Its very self explanatory.