Uri/remove negate argument #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymoss
reviewed
Jan 27, 2022
henrymoss
reviewed
Jan 27, 2022
Comment on lines
+71
to
+86
| if isinstance(function, TrajectoryFunctionClass): | ||
| # we want to negate the trajectory function but otherwise leave it alone, | ||
| # as it may have e.g. update and resample methods | ||
|
|
||
| class NegatedTrajectory(type(function)): # type: ignore[misc] | ||
| def __call__(self, x: TensorType) -> TensorType: | ||
| return -1.0 * super().__call__(x) | ||
|
|
||
| function.__class__ = NegatedTrajectory | ||
| else: | ||
|
|
||
| def negated_trajectory(x: TensorType) -> TensorType: | ||
| return -1.0 * function(x) | ||
|
|
||
| function = negated_trajectory | ||
|
|
hstojic
reviewed
Jan 27, 2022
| @@ -348,15 +347,12 @@ def test_rff_trajectory_sampler_can_return_negative_trajectory(negate: bool) -> | |||
| ) # need a gpflow kernel object for random feature decompositions | |||
|
|
|||
| sampler = RandomFourierFeatureTrajectorySampler(model, num_features=100) | |||
There was a problem hiding this comment.
this is not executed by the new continuous TS so I dont see why would trajectory be negated, by default it should be positive?
There was a problem hiding this comment.
essentially this does not test that a negative trajectory can be returned - this should probably be moved to the cont TS test file and tested there properly
There was a problem hiding this comment.
As @henrymoss noted, this test no longer doing anything useful, so I've removed it.
hstojic
reviewed
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the negate argument from get_trajectory by having GreedyContinuousThompsonSampling update the callable trajectory to negate it.