Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for keras models part 5 - integration tests #468

Merged
merged 11 commits into from
Jan 25, 2022
Merged

support for keras models part 5 - integration tests #468

merged 11 commits into from
Jan 25, 2022

Conversation

hstojic
Copy link
Collaborator

@hstojic hstojic commented Jan 11, 2022 •
edited
Loading

support for neural nets with Keras comes in five parts:

  1. interface (done)
  2. utilities (done)
  3. model and architectures (deep ensembles only - done)
  4. trajectory sampler (under review but independent)
  5. integration tests and notebook - this PR

(also simplified BO integration tests)

uri-granta
uri-granta reviewed Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@uri-granta uri-granta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall (apart from the notebook which I haven't looked at yet, but will do next)

uri-granta
uri-granta approved these changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@uri-granta uri-granta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one question.

@hstojic hstojic merged commit f3162a0 into develop Jan 25, 2022
@hstojic hstojic deleted the hstojic/keras_integration branch January 25, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-granta uri-granta uri-granta approved these changes

@henrymoss henrymoss Awaiting requested review from henrymoss

@vpicheny vpicheny Awaiting requested review from vpicheny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hstojic @vpicheny @uri-granta