integration tests for active learning #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpicheny
reviewed
Nov 29, 2021
vpicheny
reviewed
Nov 29, 2021
vpicheny
reviewed
Nov 29, 2021
vpicheny
reviewed
Nov 29, 2021
vpicheny
reviewed
Nov 29, 2021
vpicheny
reviewed
Nov 29, 2021
hstojic
commented
Nov 30, 2021
hstojic
commented
Nov 30, 2021
hstojic
commented
Nov 30, 2021
hstojic
commented
Nov 30, 2021
vpicheny
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
active learning algos were missing integration tests, this would close #439
tests are a bit slow, which is to be expected I guess, since we want to be reasonably sure that we are really learning the function or the feasibility set we do need to run more iterations than usual
something to discuss: should we cover batch versions, async rules, trust region, tensorboard? (mirroring the optimization tests...)