Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit notebooks to 80 characters #432

Merged
merged 5 commits into from
Nov 26, 2021

Conversation

uri-granta
Copy link
Collaborator

No description provided.

@apaleyes
Copy link
Collaborator

Very nice! Just curious: how does this bypass the [tool.black] section in toml file, that explicitly says to ignore pct.py files?

Copy link
Collaborator

@hstojic hstojic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@uri-granta uri-granta requested a review from henrymoss November 25, 2021 09:18
@uri-granta
Copy link
Collaborator Author

Just curious: how does this bypass the [tool.black] section in toml file, that explicitly says to ignore pct.py files?

Passing it explicitly as an argument takes precedence over the exclude setting (unless you use force-exclude, which we don't).

@uri-granta uri-granta merged commit 83acde9 into secondmind-labs:develop Nov 26, 2021
@uri-granta uri-granta deleted the uri/notebook_format branch November 26, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial code snippets should be no more than 80 characters wide to avoid drag bars
3 participants