notebook with data normalization #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaleyes
reviewed
Oct 21, 2021
There was a problem hiding this comment.
Reads very clear and explains the general idea well. Some phrasing could be better, but @henrymoss and @saadhamidml can comment on that better than me. Nevertheless, some notes on content below.
| model.optimize(standardised_data) | ||
|
|
||
| # Asking for a new point to observe | ||
| ask_tell = AskTellOptimizer(search_space, standardised_data, model) |
There was a problem hiding this comment.
Another illustration why we need something like tell_model @henrymoss !
apaleyes
approved these changes
Oct 22, 2021
sd-hmd
reviewed
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #379, showing how to data standardisation as an example of data transformation using the ask-tell interface. Until we figure out how to address the issue more completely it will be a useful resource for users.