-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added trid objective function #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comments
docs/refs.bib
Outdated
@misc{ssurjano2021, | ||
author = {Surjanovic, S. and Bingham, D.}, | ||
title = {Virtual Library of Simulation Experiments: Test Functions and Datasets}, | ||
howpublished = {Retrieved October 15, 2021, from \url{http://www.sfu.ca/~ssurjano}} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other citations have two spaces indent
def trid(x: TensorType, d: int = 10) -> TensorType: | ||
""" | ||
The Trid function over :math:`[-d^2, d^2]` for all i=1,...,d. Dimensionality is determined | ||
by the parameter ``d`` and it has a global minimum. This functions has large variation in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by the parameter ``d`` and it has a global minimum. This functions has large variation in | |
by the parameter ``d`` and it has a global minimum. This function has large variation in |
output which makes it challenging for Bayesian optimisation with vanilla Gaussian processes | ||
with non-stationary kernels. Models that can deal with non-stationarities, such as deep | ||
Gaussian processes, can be useful for modelling these functions. See :cite:`hebbal2019bayesian` | ||
and https://www.sfu.ca/~ssurjano/trid.html for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe insert citation instead of an url here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url specifically points to trid part of the website
objective function from Hebbal et al 2019 (https://arxiv.org/abs/1905.03350), vanilla GPs seem to perform poorly, while DGPs well
might also be good testing ground for data transformation/normalisation (if and when we come to that)