Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPflux notebook #364

Merged
merged 6 commits into from
Oct 6, 2021
Merged

GPflux notebook #364

merged 6 commits into from
Oct 6, 2021

Conversation

sebastianober
Copy link
Collaborator

No description provided.

apaleyes
apaleyes approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@apaleyes apaleyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although it isn't very informed opinion...

One thing worth thinking about is moving some repetitive code into functions (particularly around plotting). But that's likely down to personal taste

hstojic
hstojic reviewed Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@hstojic hstojic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks quite good, you can improve the text surrounding the code, add a reference etc
almost there!

@sebastianober
Copy link
Collaborator Author

@hstojic everything good to merge? I've tried to address your comments.

hstojic
hstojic approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@hstojic hstojic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge in my opinion

@sebastianober sebastianober merged commit 6b34daf into develop Oct 6, 2021
@sebastianober sebastianober deleted the sebastian/dgp_notebook branch October 6, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaleyes apaleyes apaleyes approved these changes

@hstojic hstojic hstojic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastianober @apaleyes @hstojic