Refactor GIBBON to avoid retracing #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymoss
reviewed
Sep 16, 2021
Comment on lines
+467
to
469
| tf.debugging.assert_rank(samples, 2) | ||
| tf.debugging.assert_positive(len(samples)) | ||
| self._samples.assign(samples) |
There was a problem hiding this comment.
I've added in a few of these extra asserts. Was there a reason not to have these before? I guess they will need unit testing now
Comment on lines
+1935
to
+1957
| def _get_min_value_samples( | ||
| model: ProbabilisticModel, | ||
| dataset: Dataset, | ||
| sampled_points: TensorType, | ||
| num_samples: int, | ||
| use_thompson: bool, | ||
| num_fourier_features: Optional[int] = None, | ||
| ) -> TensorType: | ||
|
|
||
| if not use_thompson: # use Gumbel sampler | ||
| sampler: ThompsonSampler = GumbelSampler(num_samples, model) | ||
| elif num_fourier_features is not None: # use approximate Thompson sampler | ||
| sampler = RandomFourierFeatureThompsonSampler( | ||
| num_samples, | ||
| model, | ||
| dataset, | ||
| sample_min_value=True, | ||
| num_features=num_fourier_features, | ||
| ) | ||
| else: # use exact Thompson sampler | ||
| sampler = ExactThompsonSampler(num_samples, model, sample_min_value=True) | ||
|
|
||
| return sampler.sample(sampled_points) |
There was a problem hiding this comment.
This needs unit testing
There was a problem hiding this comment.
These is a private function so wouldn't normally be unit tested directly. The code paths are tested instead via MinValueEntropySearch and GIBBON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.