Use extend-exclude for flake8 and black #348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a bit more extensive use of
extend-exclude
option, pun intended.I've hit a couple of issues running all format checks because in my dev setup
.venv
lives in the project root. So both tools would validated files inside this.venv
.Black by default can respect .gitignore file, which covers .venv, .tox and many more. But if you use
exclude
option, this default behavior is overriden. So for black we simply useextend-exclude
instead ofexclude
, and then clean up in other places.flake8 doesn't respect .gitignore at all, but it has sensbile defaults that cover .tox. Thus for flake8 we only need to add
.venv
to the list of excludes, with the sameextend-exclude
option.While this is wasn't an issue in Trieste development so far, I argue it would very contributor-friendly to support .venv in project root, as this setup is quite popular.