Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make task mypy and tox -e tests more resilient #333

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

uri-granta
Copy link
Collaborator

No description provided.

tox.ini Outdated
@@ -34,9 +34,9 @@ commands =
format: flake8 --count .
format: isort --check .
tests: pip install . -r tests/requirements.txt -c tests/constraints.txt
tests: pytest
tests: CUDA_VISIBLE_DEVICES="" pytest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be
CUDA_VISIBLE_DEVICES="" & pytest?

Copy link
Collaborator

@hstojic hstojic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hstojic hstojic added the code quality Improvements to robustness or maintainability label Aug 18, 2021
@hstojic hstojic linked an issue Aug 18, 2021 that may be closed by this pull request
@hstojic hstojic added the bug Something isn't working label Aug 18, 2021
@uri-granta uri-granta force-pushed the uri/build_resilience branch from d2657e0 to 2f7e4b5 Compare August 18, 2021 10:41
@uri-granta uri-granta merged commit d8b4650 into secondmind-labs:develop Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality Improvements to robustness or maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests sometimes fail when GPU is used
2 participants