-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decomposition of model_interfaces.py #272
Conversation
Finally updated all this. Merged in latest I also attempted to fix I haven't touched optimizers yet, not crucial for now as everything can work without that part, so I left it for another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I'll take a look at the typing next.
Note that it'll result in a small merge conflict for #320 (cc @sebastianober)
Also probably worth building the docs manually using tox to see that they still look ok.
Looking in more detail at the typing failures, there are quite a few issues. Happy to discuss. |
All fixed now and merged in latest I returned |
Hello,
here is a draft for decomposing the model_interfaces (now also renamed to interfaces)
some remarks: