SL-18721 Shutdown fixes #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchcat
approved these changes
Jan 20, 2024
marchcat
reviewed
Jan 20, 2024
| @@ -33,4 +33,6 @@ | |||
| //Why? Because BOOL | |||
| void launchApplication(const std::string* app_name, const std::vector<std::string>* args); | |||
|
|
|||
| void force_ns_sxeption() { [NSEXception raise:@"Forced NSException"] }; | |||
There was a problem hiding this comment.
Suggested change
| void force_ns_sxeption() { [NSEXception raise:@"Forced NSException"] }; | |
| void force_ns_sxeption() { [NSException raise:@"Forced NSException"] }; |
Mac build is unhappy. Probably due to typo.
There was a problem hiding this comment.
Thank you, that's why it's a draft, will run it on mac a bit later.
akleshchev
force-pushed
the
andreyk/SL-18721
branch
from
ae9e2bd to
3790d83
Compare
maxim-productengine
approved these changes
Jan 21, 2024
akleshchev
force-pushed
the
andreyk/SL-18721
branch
from
3790d83 to
f4cf0f6
Compare
marchcat
approved these changes
Jan 21, 2024
1. After window closes viewer still takes some time to shut down, so added splash screen to not confuse users (and to see if something gets stuck) 2. Having two identical mWindowHandle caused confusion for me, so I split them. It looks like there might have been issues with thread being stuck because thread's handle wasn't cleaned up. 3. Made region clean mCacheMap immediately instead of spending time making copies on shutdown
akleshchev
force-pushed
the
andreyk/SL-18721
branch
from
f4cf0f6 to
c01e4ba
Compare
|
Archived issue: https://github.com/secondlife/jira-archive-internal/issues/68974 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.