Prevent the creation of temporary objects that will be discarded. #5037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyeMutt
reviewed
Nov 24, 2025
| if ( pContent.has(NAVMESH_DATA_FIELD) ) | ||
| { | ||
| const LLSD::Binary &value = pContent.get(NAVMESH_DATA_FIELD).asBinary(); | ||
| LLSD::Binary value = pContent.get(NAVMESH_DATA_FIELD).asBinary(); |
Contributor
There was a problem hiding this comment.
I'd suggest this method to suppress the related compiler warning. It avoids creating an additional copy of the binary data vector.
Suggested change
| LLSD::Binary value = pContent.get(NAVMESH_DATA_FIELD).asBinary(); | |
| LLSD nav_data = pContent.get(NAVMESH_DATA_FIELD); | |
| const LLSD::Binary& value = nav_data.asBinary(); |
Contributor
Author
There was a problem hiding this comment.
Thank you. I refixed it.
AiraYumi
force-pushed
the
develop-linux
branch
from
be0597f to
0894784
Compare
Contributor
|
Thank you. Is there anything our QA can test? I see that it's navmesh related and that .asBinary() returned an object that can expire before newStr, but I'm not sure what scenario this can be tested in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By returning the actual object instead of the temporary object's LLSD, we prevent reading undefined areas.