#4656 Don't scroll to a child that is already in view and can not fit #4940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchcat
approved these changes
Nov 6, 2025
akleshchev
force-pushed
the
andreyk/viewer_4656_2
branch
2 times, most recently
from
168dbe9 to
3f47f87
Compare
maxim-productengine
approved these changes
Nov 6, 2025
akleshchev
force-pushed
the
andreyk/viewer_4656_2
branch
from
3f47f87 to
676ab44
Compare
akleshchev
force-pushed
the
andreyk/viewer_4656_2
branch
from
676ab44 to
532fea3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, if a 700-high child already takes majority of a 400-high parent, don't scroll to the bottom. Scroll in every other case.