Skip to content

#4724 Fix performance problems with My Outfits #4731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

#4724 Fix performance problems with My Outfits #4731

merged 1 commit into from
Sep 24, 2025

Conversation

@akleshchev
Copy link
Contributor

@akleshchev akleshchev commented Sep 22, 2025 •
edited
Loading

Multiple problems:

  1. When there are multiple lists they were hoarding idle callback's time
  2. Outfit list was taking 50ms per frame to complete it's work thus effectively freezing viewer
  3. LLAccordionCtrl::arrange() was extremely expensive due to constant text reflows

@akleshchev akleshchev marked this pull request as draft September 22, 2025 21:16
@akleshchev akleshchev linked an issue Sep 23, 2025 that may be closed by this pull request
The list->setForceRefresh(true); during outfits loading process stalls the viewer if really large amount of outfits is involved #4724
Open
@akleshchev akleshchev requested a review from marchcat September 23, 2025 16:58
@akleshchev akleshchev marked this pull request as ready for review September 23, 2025 16:58
@akleshchev akleshchev merged commit c2460e2 into develop Sep 24, 2025
23 of 25 checks passed
@akleshchev akleshchev deleted the andreyk/vwr-4724 branch September 24, 2025 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marchcat marchcat marchcat approved these changes

@maxim-productengine maxim-productengine maxim-productengine approved these changes

Assignees

No one assigned

Labels

c/cpp llui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The list->setForceRefresh(true); during outfits loading process stalls the viewer if really large amount of outfits is involved

4 participants

@akleshchev @marchcat @maxim-productengine