-
Notifications
You must be signed in to change notification settings - Fork 94
#4604 Reduce draw distance when low on RAM #4610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7adaa7b to
77f1b29
Compare
77f1b29 to
6387130
Compare
a544b36 to
8714206
Compare
8714206 to
75b0d09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements memory-aware graphics optimizations to handle low-RAM scenarios by reducing draw distance and warning users about high quality settings on low-memory systems.
- Dynamically reduces draw distance when system memory is low and texture discard bias is high
- Adds a user notification warning when attempting to use high graphics settings with insufficient RAM
- Modifies texture memory management to be more aggressive when system memory is critically low
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| notifications.xml | Adds new warning notification for low-memory high-quality settings |
| llvocache.cpp | Implements draw distance reduction based on memory constraints |
| llviewertexture.h | Adds new method declarations for memory budget calculations |
| llviewertexture.cpp | Implements memory budget factor calculation and refactors memory checking |
| llviewermessage.cpp | Applies memory-limited draw distance to agent updates |
| llfloaterpreference.h | Adds tracking for previous quality level |
| llfloaterpreference.cpp | Implements quality level warning logic for low-memory systems |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eab4a57 to
fe392f0
Compare
#4604 Reduce draw distance when low on RAM
Textures already affect draw distance to some extent, so decided to expand that code to cut draw distance up to two times when ram is low.
Please doublecheck logic in LLViewerTexture::updateClass()
#4604 Warn user off high settings when on low-RAM hardware
A basic ok/cancel warning that throws user to 'med+' if canceled
Please check new notification's wording.