Skip to content

Conversation

@akleshchev
Copy link
Contributor

@akleshchev akleshchev commented Aug 27, 2025

#4604 Reduce draw distance when low on RAM
Textures already affect draw distance to some extent, so decided to expand that code to cut draw distance up to two times when ram is low.
Please doublecheck logic in LLViewerTexture::updateClass()

#4604 Warn user off high settings when on low-RAM hardware
A basic ok/cancel warning that throws user to 'med+' if canceled
Please check new notification's wording.

@akleshchev akleshchev force-pushed the andreyk/viewer_4604 branch 2 times, most recently from 7adaa7b to 77f1b29 Compare August 28, 2025 14:43
@akleshchev akleshchev marked this pull request as draft August 28, 2025 16:38
@akleshchev akleshchev force-pushed the andreyk/viewer_4604 branch from 77f1b29 to 6387130 Compare August 28, 2025 17:43
@akleshchev akleshchev requested a review from Geenz August 28, 2025 20:10
@akleshchev akleshchev force-pushed the andreyk/viewer_4604 branch from a544b36 to 8714206 Compare August 28, 2025 20:35
@github-actions github-actions bot removed the c/cpp label Aug 28, 2025
@akleshchev akleshchev force-pushed the andreyk/viewer_4604 branch from 8714206 to 75b0d09 Compare August 28, 2025 21:02
@github-actions github-actions bot added the c/cpp label Aug 28, 2025
@akleshchev akleshchev requested a review from Copilot August 28, 2025 21:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements memory-aware graphics optimizations to handle low-RAM scenarios by reducing draw distance and warning users about high quality settings on low-memory systems.

  • Dynamically reduces draw distance when system memory is low and texture discard bias is high
  • Adds a user notification warning when attempting to use high graphics settings with insufficient RAM
  • Modifies texture memory management to be more aggressive when system memory is critically low

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
notifications.xml Adds new warning notification for low-memory high-quality settings
llvocache.cpp Implements draw distance reduction based on memory constraints
llviewertexture.h Adds new method declarations for memory budget calculations
llviewertexture.cpp Implements memory budget factor calculation and refactors memory checking
llviewermessage.cpp Applies memory-limited draw distance to agent updates
llfloaterpreference.h Adds tracking for previous quality level
llfloaterpreference.cpp Implements quality level warning logic for low-memory systems

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@akleshchev akleshchev force-pushed the andreyk/viewer_4604 branch from eab4a57 to fe392f0 Compare August 28, 2025 21:34
@akleshchev akleshchev linked an issue Aug 29, 2025 that may be closed by this pull request
@akleshchev akleshchev marked this pull request as ready for review August 29, 2025 16:50
@akleshchev akleshchev merged commit 479fee9 into develop Aug 29, 2025
15 checks passed
@akleshchev akleshchev deleted the andreyk/viewer_4604 branch August 29, 2025 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce draw distance when low on memory and OOM countermeasures

4 participants