Fix: ignore *pass-on* counters when detecting left-button grabs from llTakeControl

[Sekkmer]

A script that takes CONTROL_ML_LBUTTON with pass_on = TRUE should not prevent the viewer from normal clicking in mouse look, yet in practice it does:

llTakeControls(CONTROL_ML_LBUTTON, TRUE, TRUE);

This happens because LLAgent::leftButtonGrabbed() treats “pass-on” requests as a full grab, unlike the other …Grabbed() helpers.

ref: Wiki: llTakeControls

Solution

Remove the two mControlsTakenPassedOnCount checks; the function now tests only the real grab counters, exactly like rotateGrabbed(), upGrabbed(), etc.

Testing

1. Drop the script below into any prim, accept the permission request

default {
    state_entry() {
        llRequestPermissions(llGetOwner(), PERMISSION_TAKE_CONTROLS);
    }
    run_time_permissions(integer perm) {
        if(PERMISSION_TAKE_CONTROLS & perm) {
            llTakeControls(CONTROL_ML_LBUTTON, TRUE, TRUE);              
        }
    }
    control(key id, integer level, integer edge)
    {}
}

2. Enter mouse look (first person mode)
   Before this patch you cannot click doors, HUDs, etc.
   After this patch clicks work normally.

Note

I only tested this change on Firestorm as building LL viewer on Linux is not straight forward, but this issue is also present in LL viewer and the code is exactly the same, here is the corresponding PR on FS side: FS PR #113

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[Sekkmer]

I have read the CLA Document and I hereby sign the CLA

[marchcat]

Thank you for the contribution!

[marchcat]

I only tested this change on Firestorm as building LL viewer on Linux is not straight forward, but this issue is also present in LL viewer and the code is exactly the same

Checked on LL viewer and it works as described.