Clean up LLUI and fix/add suggestions from VS #3933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # indra/llui/lltextbase.h # indra/llui/lltexteditor.h # indra/llwindow/llwindowsdl.cpp
|
This looks fine, but I'm gonna take some time to go through it to make sure I understand the gist of it. Maybe see if this copilot code review feature is worth a damn while I'm at it. It looks like it's some more or less straightforward cleanup, just it touches a lot of files for stuff like const correctness. |
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the LLUI code by adding const qualifiers to member functions and updating constant definitions, while also removing unused functions suggested by VS.
- Added const qualifiers where appropriate
- Updated several constant definitions to use constexpr
- Removed obsolete functions that are no longer in use
Reviewed Changes
Copilot reviewed 68 out of 68 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| indra/llui/llkeywords.cpp | Added const qualifier to getColorGroup |
| indra/llui/llfolderviewitem.h | Added const qualifier to isSingleFolderMode and removed resort function |
| indra/llui/llfolderview.h | Added const qualifiers to various getters |
| indra/llui/llfocusmgr.h | Added const qualifier to getKeystrokesOnly |
| indra/llui/llflyoutbutton.h | Replaced virtual draw() with override |
| indra/llui/llfloaterreglistener.h | Removed unneeded include |
| indra/llui/llfloater.h | Updated constant definitions to constexpr and added const qualifiers to getters; removed createMinimizeButton() |
| indra/llui/llfloater.cpp | Added const qualifier to getCanDrag |
| indra/llui/llflatlistview.h | Added const qualifier to getters |
| indra/llui/llflatlistview.cpp | Added const qualifier to getForceShowingUnmatchedItems() |
| indra/llui/llflashtimer.h & .cpp | Added const qualifiers to timer status functions |
| indra/llui/llfiltereditor.h | Updated handleKeystroke() to use override keyword |
| indra/llui/lldraghandle.h | Added const qualifier to getButtonsRect |
| indra/llui/lldockcontrol.h & .cpp | Added const qualifiers to relevant getters |
| indra/llui/lldockablefloater.h | Added const qualifiers to docking related getters |
| indra/llui/llcontainerview.h | Added override qualifiers for virtual functions |
| indra/llui/llcheckboxctrl.h | Updated constant definitions to constexpr and added const qualifier to get() |
| indra/llui/llaccordionctrltab.h | Added const qualifiers to getters |
Comments suppressed due to low confidence (2)
indra/llui/llfolderviewitem.h:417
- Ensure that the removal of the 'resort' function is intentional and that any dependent calls have been refactored accordingly.
void resort(LLFolderViewItem* item);
indra/llui/llfloater.h:427
- Verify that the removal of 'createMinimizeButton' is intentional and that its functionality is being handled elsewhere.
void createMinimizeButton();
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another restored missing contribution from old
developbranch.