Skip to content

Fix annoying llhttpdate test on windows and macos #3909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

Fix annoying llhttpdate test on windows and macos #3909

merged 1 commit into from
Apr 14, 2025

Conversation

marchcat
Copy link
Contributor

@marchcat marchcat commented Apr 14, 2025 •
edited
Loading

const char *en_locale = "english"; fails on windows;

const char *en_locale = "en_GB.UTF-8"; is inconsistent on macos.

@github-actions github-actions bot added the c/cpp label Apr 14, 2025
@marchcat marchcat requested a review from Copilot April 14, 2025 22:34
Copilot
Copilot AI reviewed Apr 14, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@marchcat marchcat marked this pull request as ready for review April 14, 2025 23:55
@marchcat marchcat merged commit 5a893f2 into marchcat/maint-c-restore Apr 14, 2025
6 checks passed
@marchcat marchcat deleted the marchcat/maint-c-annoying-test branch April 14, 2025 23:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
c/cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marchcat